Update old syntax for action default_icon to populate 19 and 38px icons

chrome/common/extensions/api/extension_action/action_info.cc

Index: chrome/common/extensions/api/extension_action/action_info.cc
diff --git a/chrome/common/extensions/api/extension_action/action_info.cc b/chrome/common/extensions/api/extension_action/action_info.cc
index f974c1d0bc0bc179590b3eaa7e2397985e6a94fa..847371c51ce4d5338bc0b5adf3123990f50fa357 100644
--- a/chrome/common/extensions/api/extension_action/action_info.cc
+++ b/chrome/common/extensions/api/extension_action/action_info.cc
@@ -102,7 +102,7 @@ scoped_ptr<ActionInfo> ActionInfo::Load(const Extension* extension,
     } else if (dict->GetString(keys::kPageActionDefaultIcon, &default_icon) &&
                manifest_handler_helpers::NormalizeAndValidatePath(
                    &default_icon)) {
-      result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION,
+      result->default_icon.Add(extension_misc::EXTENSION_ICON_ACTION * 2,

[not at google - send to devlin, 2014/08/27 01:11:35]

Actually this should be multiplying by
extension_misc::kNumExtensionActionIconSizes, not 2. And you should add a
comment:

// Choose the most optimistic (highest) icon density - e.g. 38 not 19 -
regardless of the actual icon resolution, whatever that happens to be. Code
elsewhere knows how to scale 38 down to 19.

                                default_icon);
     } else {
       *error = base::ASCIIToUTF16(errors::kInvalidPageActionIconPath);