Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 508763002: Hook up link pools in GN. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/d54674267a8569ea90c5f8512eff690bcb86b1d4 Cr-Commit-Position: refs/heads/master@{#292261}

Patch Set 1 #

Patch Set 2 : parens #

Total comments: 2

Patch Set 3 : default to 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -25 lines) Patch
M tools/gn/function_toolchain.cc View 1 2 6 chunks +55 lines, -12 lines 0 comments Download
M tools/gn/ninja_build_writer.h View 4 chunks +5 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 5 chunks +11 lines, -1 line 0 comments Download
M tools/gn/ninja_toolchain_writer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/gn/ninja_writer.cc View 2 chunks +8 lines, -1 line 0 comments Download
M tools/gn/tool.h View 2 chunks +0 lines, -9 lines 0 comments Download
M tools/gn/toolchain.h View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gn/toolchain.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
brettw@chromium.org changed reviewers: + scottmg@chromium.org
6 years, 3 months ago (2014-08-26 21:25:04 UTC) #1
brettw
6 years, 3 months ago (2014-08-26 21:25:05 UTC) #2
scottmg
lgtm https://codereview.chromium.org/508763002/diff/20001/tools/gn/function_toolchain.cc File tools/gn/function_toolchain.cc (right): https://codereview.chromium.org/508763002/diff/20001/tools/gn/function_toolchain.cc#newcode237 tools/gn/function_toolchain.cc:237: " there is no limit to \"alink\" steps. ...
6 years, 3 months ago (2014-08-26 22:41:49 UTC) #3
brettw
I made the default 0 and documented this. After I push the new binary I ...
6 years, 3 months ago (2014-08-26 23:01:49 UTC) #4
brettw
Committed patchset #3 (id:40001) to pending queue manually as 2f6d6c1 (presubmit successful).
6 years, 3 months ago (2014-08-27 23:05:12 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:24 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d54674267a8569ea90c5f8512eff690bcb86b1d4
Cr-Commit-Position: refs/heads/master@{#292261}

Powered by Google App Engine
This is Rietveld 408576698