Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 508763002: Hook up link pools in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: default to 0 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/ninja_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_toolchain_writer.cc
diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc
index ae2b6c974e5339832a81a77e543855c8254d5c3f..0e26db13afcb08ee61f84dd77c710f453fab759b 100644
--- a/tools/gn/ninja_toolchain_writer.cc
+++ b/tools/gn/ninja_toolchain_writer.cc
@@ -105,8 +105,11 @@ void NinjaToolchainWriter::WriteToolRule(const Toolchain::ToolType type,
out_ << kIndent << "deps = msvc" << std::endl;
}
- if (!tool->pool().empty())
- out_ << kIndent << "pool = " << tool->pool() << std::endl;
+ // The link pool applies to linker tools. Don't count TYPE_ALINK since
+ // static libraries are not generally intensive to write.
+ if (type == Toolchain::TYPE_SOLINK || type == Toolchain::TYPE_LINK)
+ out_ << kIndent << "pool = link_pool\n";
+
if (tool->restat())
out_ << kIndent << "restat = 1" << std::endl;
}
« no previous file with comments | « tools/gn/ninja_build_writer.cc ('k') | tools/gn/ninja_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698