Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 508643002: Vector-ic project, current state (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
5 years, 7 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

This is a monster CL, from which useful slices are carved off. Not ready for review :). At the moment, contents are: * --vector-ics flag turned on. * hydrogen code stub implementation of non-patching LoadIC and KeyedLoadIC. * Alterations to IC, be able to work with a vector instead of patching. * FeedbackNode class hierarchy to encapsulate the different ways of configuring a node (node = vector[slot]). * typing.cc / type-info.cc changes to read from the vector for crankshaft. * Really messy part: saving of vector/slot registers for IC handlers. Ey yi yi. * The monomorphic ICs are not being cleared at gc time, but they are actually leaking. We can't just check this in for that reason! :) [Closed since this has landed by now in other CLs]

Patch Set 1 #

Patch Set 2 : More basics in place. #

Patch Set 3 : Sort of works. #

Patch Set 4 : Starting to get feedback for crankshaft. #

Patch Set 5 : FeedbackNode renamed to FeedbackNexus. #

Patch Set 6 : Repaired RayTrace degrade. #

Patch Set 7 : REBASE. #

Patch Set 8 : Small fixes. #

Patch Set 9 : Rebase. #

Patch Set 10 : Including dubious crankshaft optimization. #

Patch Set 11 : Removed crankshaft vector-avoid behavior. #

Patch Set 12 : Added platform dependent version of dispatchers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+811 lines, -91 lines) Patch
M src/code-stubs.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +38 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +242 lines, -8 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +11 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 7 8 9 10 8 chunks +84 lines, -22 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +171 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +61 lines, -23 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 3 4 1 chunk +8 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -4 lines 0 comments Download
M src/ic/access-compiler.h View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.h View 1 2 3 4 2 chunks +14 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 3 4 5 6 2 chunks +27 lines, -0 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 3 4 5 6 7 8 7 chunks +65 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +37 lines, -11 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (28 generated)
mvstanton
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-27 12:25:11 UTC) #1
mvstanton
6 years, 2 months ago (2014-10-02 16:40:30 UTC) #6
Hi guys, this isn't for review, but just to get it on your radar. Until today,
all KeyedLoads were going generic right away, now they are implemented. Still
plenty of work to do to pass tests.

If you want to look at anything now, see type-feedback-vector.h, and ic.h and
ic.cc.

Thanks,
--Michael

Powered by Google App Engine
This is Rietveld 408576698