Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 50813002: Fix bug in erosion filtering (Closed)

Created:
7 years, 1 month ago by robertphillips
Modified:
7 years, 1 month ago
CC:
skia-review_google.com
Visibility:
Public.

Description

Noticed this while testing out the "don't reuse scratch textures" patch. Prior to this patch, when the erosion code received a scratch texture larger then necessary the bottom was being over-eroded. This CL fills the filter padding area with white in this case to prevent the over erosion. (When scratch textures aren't reused we always get an exactly sized texture so the old clear to black was having no effect).

Patch Set 1 #

Patch Set 2 : Added suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 1 month ago (2013-10-29 13:45:22 UTC) #1
Stephen White
On 2013/10/29 13:45:22, robertphillips wrote: Good catch! LGTM
7 years, 1 month ago (2013-10-29 13:56:30 UTC) #2
robertphillips
committed as r11966
7 years, 1 month ago (2013-10-29 13:59:45 UTC) #3
Stephen White
7 years, 1 month ago (2013-10-29 14:06:19 UTC) #4
Message was sent while issue was closed.
Although now that I think about it, this is part of a larger class of problems:
morphology shouldn't be sampling outside of the crop rect, in either the source
image or the temporaries. I've filed
https://code.google.com/p/skia/issues/detail?id=1766 for that.

Powered by Google App Engine
This is Rietveld 408576698