[Mac] Fixes a bug where an ExtensionPopupController object's pointer was neve...

[Mac] Fixes a bug where an ExtensionPopupController object's pointer was never being nil'd out when it resigned its key state, leading to a obj_msgSend from a dirty pointer. Also makes sure that other areas of Page Action code are properly using nil instead of NULL where necessary.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35109

[Mark Mentovai, 2009-12-21 20:54:32]

LGTM
ho ho ho

http://codereview.chromium.org/508010/diff/1/3
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/508010/diff/1/3#newcode286
chrome/browser/cocoa/extensions/browser_actions_controller.mm:286: if (popup ==
nil || Details<ExtensionHost>([popup host]) != details)
Things are sometimes a tiny bit easier to follow if early returns aren't
sprinkled throughout functions.   Maybe you should ! this condition and put
[owner_ hidePopup] inside the controlled block, and get rid of the early return.

http://codereview.chromium.org/508010/diff/1/3#newcode322
chrome/browser/cocoa/extensions/browser_actions_controller.mm:322:
popupController_ = nil;
Not strictly necessary, because -alloc zero-fills the entire object.  I guess
you can leave this in if you like being explicit, but it's customary not to set
things to nil in -init methods.

http://codereview.chromium.org/508010/diff/1/5
File chrome/browser/cocoa/location_bar_view_mac.mm (right):

http://codereview.chromium.org/508010/diff/1/5#newcode627
chrome/browser/cocoa/location_bar_view_mac.mm:627: if (popup_controller_ == nil
||
Same comment about early returns applies here.

[Bons, 2009-12-21 21:01:41]

http://codereview.chromium.org/508010/diff/1/3
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/508010/diff/1/3#newcode286
chrome/browser/cocoa/extensions/browser_actions_controller.mm:286: if (popup ==
nil || Details<ExtensionHost>([popup host]) != details)
On 2009/12/21 20:54:32, Mark Mentovai wrote:
> Things are sometimes a tiny bit easier to follow if early returns aren't
> sprinkled throughout functions.   Maybe you should ! this condition and put
> [owner_ hidePopup] inside the controlled block, and get rid of the early
return.

Done.

http://codereview.chromium.org/508010/diff/1/3#newcode322
chrome/browser/cocoa/extensions/browser_actions_controller.mm:322:
popupController_ = nil;
On 2009/12/21 20:54:32, Mark Mentovai wrote:
> Not strictly necessary, because -alloc zero-fills the entire object.  I guess
> you can leave this in if you like being explicit, but it's customary not to
set
> things to nil in -init methods.

Done.

http://codereview.chromium.org/508010/diff/1/5
File chrome/browser/cocoa/location_bar_view_mac.mm (right):

http://codereview.chromium.org/508010/diff/1/5#newcode627
chrome/browser/cocoa/location_bar_view_mac.mm:627: if (popup_controller_ == nil
||
On 2009/12/21 20:54:32, Mark Mentovai wrote:
> Same comment about early returns applies here.

Done.