chrome/browser/cocoa/extensions/extension_popup_controller.mm - Issue 508010: [Mac] Fixes a bug where an ExtensionPopupController object's pointer was neve...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/extensions/extension_popup_controller.mm

Issue 508010: [Mac] Fixes a bug where an ExtensionPopupController object's pointer was neve... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/cocoa/extensions/browser_actions_controller.mm ('K') | « chrome/browser/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/cocoa/location_bar_view_mac.h » ('j') | chrome/browser/cocoa/location_bar_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/extensions/extension_popup_controller.mm

===================================================================

--- chrome/browser/cocoa/extensions/extension_popup_controller.mm (revision 35091)

+++ chrome/browser/cocoa/extensions/extension_popup_controller.mm (working copy)

@@ -13,6 +13,7 @@

#include "chrome/browser/extensions/extension_host.h"

#include "chrome/browser/extensions/extension_process_manager.h"

#include "chrome/browser/profile.h"

+#include "chrome/common/notification_service.h"

// The minimum/maximum dimensions of the popup.

// The minimum is just a little larger than the size of the button itself.

@@ -95,7 +96,10 @@

- (void)windowDidResignKey:(NSNotification *)notification {

DCHECK_EQ([notification object], [self window]);

- [self close];

+ NotificationService::current()->Notify(

+ NotificationType::EXTENSION_HOST_VIEW_SHOULD_CLOSE,

+ Source<Profile>(host_->profile()),

+ Details<ExtensionHost>(host_.get()));

}

- (void)close {