Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5147)

Unified Diff: build/secondary/third_party/icu/BUILD.gn

Issue 507753002: Fix clang warnings in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/opus/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/icu/BUILD.gn
diff --git a/build/secondary/third_party/icu/BUILD.gn b/build/secondary/third_party/icu/BUILD.gn
index 14d59b5636cd9728e171b387acff6ac436dcb7ae..4f7f0888634638e6ed6a1b0c710514ca7ee03388 100644
--- a/build/secondary/third_party/icu/BUILD.gn
+++ b/build/secondary/third_party/icu/BUILD.gn
@@ -46,23 +46,25 @@ config("icu_config") {
# Config used only by ICU code.
config("icu_code") {
+ cflags = []
if (is_win) {
# Disable some compiler warnings.
- cflags = [
+ cflags += [
"/wd4005", # Macro redefinition.
"/wd4068", # Unknown pragmas.
"/wd4267", # Conversion from size_t on 64-bits.
"/wd4996", # Deprecated functions.
]
} else if (is_linux) {
- cflags = [
+ cflags += [
# Since ICU wants to internally use its own deprecated APIs, don't
# complain about it.
"-Wno-deprecated-declarations",
"-Wno-unused-function",
]
- } else if (is_clang) {
- cflags = [
+ }
+ if (is_clang) {
+ cflags += [
"-Wno-deprecated-declarations",
"-Wno-logical-op-parentheses",
"-Wno-tautological-compare",
« no previous file with comments | « no previous file | third_party/opus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698