Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: build/secondary/third_party/icu/BUILD.gn

Issue 507753002: Fix clang warnings in GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/opus/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Tells icu to load an external data file rather than rely on the icudata 6 # Tells icu to load an external data file rather than rely on the icudata
7 # being linked directly into the binary. 7 # being linked directly into the binary.
8 # 8 #
9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to 9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to
10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes 10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
(...skipping 28 matching lines...) Expand all
39 } 39 }
40 40
41 include_dirs = [ 41 include_dirs = [
42 "source/common", 42 "source/common",
43 "source/i18n", 43 "source/i18n",
44 ] 44 ]
45 } 45 }
46 46
47 # Config used only by ICU code. 47 # Config used only by ICU code.
48 config("icu_code") { 48 config("icu_code") {
49 cflags = []
49 if (is_win) { 50 if (is_win) {
50 # Disable some compiler warnings. 51 # Disable some compiler warnings.
51 cflags = [ 52 cflags += [
52 "/wd4005", # Macro redefinition. 53 "/wd4005", # Macro redefinition.
53 "/wd4068", # Unknown pragmas. 54 "/wd4068", # Unknown pragmas.
54 "/wd4267", # Conversion from size_t on 64-bits. 55 "/wd4267", # Conversion from size_t on 64-bits.
55 "/wd4996", # Deprecated functions. 56 "/wd4996", # Deprecated functions.
56 ] 57 ]
57 } else if (is_linux) { 58 } else if (is_linux) {
58 cflags = [ 59 cflags += [
59 # Since ICU wants to internally use its own deprecated APIs, don't 60 # Since ICU wants to internally use its own deprecated APIs, don't
60 # complain about it. 61 # complain about it.
61 "-Wno-deprecated-declarations", 62 "-Wno-deprecated-declarations",
62 "-Wno-unused-function", 63 "-Wno-unused-function",
63 ] 64 ]
64 } else if (is_clang) { 65 }
65 cflags = [ 66 if (is_clang) {
67 cflags += [
66 "-Wno-deprecated-declarations", 68 "-Wno-deprecated-declarations",
67 "-Wno-logical-op-parentheses", 69 "-Wno-logical-op-parentheses",
68 "-Wno-tautological-compare", 70 "-Wno-tautological-compare",
69 "-Wno-switch", 71 "-Wno-switch",
70 ] 72 ]
71 } 73 }
72 } 74 }
73 75
74 component("icui18n") { 76 component("icui18n") {
75 sources = [ 77 sources = [
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 sources = [ "mac/icudtl_dat.S" ] 509 sources = [ "mac/icudtl_dat.S" ]
508 } else if (is_android) { 510 } else if (is_android) {
509 sources = [ "android/icudtl_dat.S" ] 511 sources = [ "android/icudtl_dat.S" ]
510 } else { 512 } else {
511 assert(false, "No icu data for this platform") 513 assert(false, "No icu data for this platform")
512 } 514 }
513 defines = [ "U_HIDE_DATA_SYMBOL" ] 515 defines = [ "U_HIDE_DATA_SYMBOL" ]
514 } 516 }
515 } 517 }
516 } 518 }
OLDNEW
« no previous file with comments | « no previous file | third_party/opus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698