Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 507723002: Update documentation for new perf bisect command. (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
tonyg, prasadv
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed outdated documentation from bisect output, redirected it to chromium.org documentation BUG= Committed: https://crrev.com/fd497eb344a16b4297e36f2e1e93e71bbbe767ca Cr-Commit-Position: refs/heads/master@{#292193}

Patch Set 1 #

Patch Set 2 : Added some detail to telemetry command #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M tools/bisect-perf-regression.py View 1 2 chunks +16 lines, -1 line 2 comments Download

Messages

Total messages: 11 (0 generated)
sullivan
sullivan@chromium.org changed reviewers: + prasadv@chromium.org, tony@chromium.org
6 years, 3 months ago (2014-08-26 16:28:10 UTC) #1
sullivan
I wasn't able to figure out how to get the actual perf trybot name, maybe ...
6 years, 3 months ago (2014-08-26 16:28:10 UTC) #2
tony
tony@chromium.org changed reviewers: + tonyg@chromium.org - tony@chromium.org
6 years, 3 months ago (2014-08-26 16:47:47 UTC) #3
prasadv
lgtm
6 years, 3 months ago (2014-08-27 16:20:38 UTC) #4
sullivan
The CQ bit was checked by sullivan@chromium.org
6 years, 3 months ago (2014-08-27 16:26:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/507723002/20001
6 years, 3 months ago (2014-08-27 16:27:24 UTC) #6
tonyg
https://codereview.chromium.org/507723002/diff/20001/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/507723002/diff/20001/tools/bisect-perf-regression.py#newcode241 tools/bisect-perf-regression.py:241: (Where <bot-name> comes from tools/perf/run_benchmark --browser=list) I think an ...
6 years, 3 months ago (2014-08-27 16:38:59 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 17:47:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8138e22c547f394f9666738d1a8a31d368d08d3d
6 years, 3 months ago (2014-08-27 18:43:30 UTC) #9
sullivan
https://codereview.chromium.org/507723002/diff/20001/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/507723002/diff/20001/tools/bisect-perf-regression.py#newcode241 tools/bisect-perf-regression.py:241: (Where <bot-name> comes from tools/perf/run_benchmark --browser=list) On 2014/08/27 16:38:59, ...
6 years, 3 months ago (2014-08-27 22:02:49 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd497eb344a16b4297e36f2e1e93e71bbbe767ca
Cr-Commit-Position: refs/heads/master@{#292193}

Powered by Google App Engine
This is Rietveld 408576698