Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/bisect-perf-regression.py

Issue 507723002: Update documentation for new perf bisect command. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added some detail to telemetry command Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 54695594d8ba568b7ac57fa15020a2de8e1374c6..3ed81719fe73ad02281af0bcd16341ec1e28cfd5 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -235,6 +235,15 @@ committed locally to run-perf-test.cfg.
For more details please visit
https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots"""
+REPRO_STEPS_TRYJOB_TELEMETRY = """
+To reproduce on a performance try bot:
+%(command)s
+(Where <bot-name> comes from tools/perf/run_benchmark --browser=list)
tonyg 2014/08/27 16:38:59 I think an important thing to do here is to give t
sullivan 2014/08/27 22:02:49 I'm really sorry this got committed without addres
+
+For more details please visit
+https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots
+"""
+
RESULTS_THANKYOU = """
===== THANK YOU FOR CHOOSING BISECT AIRLINES =====
Visit http://www.chromium.org/developers/core-principles for Chrome's policy
@@ -2725,7 +2734,13 @@ class BisectPerformanceMetrics(object):
command += ('\nAlso consider passing --profiler=list to see available '
'profilers.')
print REPRO_STEPS_LOCAL % {'command': command}
- print REPRO_STEPS_TRYJOB % {'command': command}
+ if bisect_utils.IsTelemetryCommand(self.opts.command):
+ telemetry_command = re.sub(r'--browser=[^\s]+',
+ '--browser=<bot-name>',
+ command)
+ print REPRO_STEPS_TRYJOB_TELEMETRY % {'command': telemetry_command}
+ else:
+ print REPRO_STEPS_TRYJOB % {'command': command}
def _PrintOtherRegressions(self, other_regressions, revision_data):
"""Prints a section of the results about other potential regressions."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698