Rename didEnterDocument and didLeaveDocument

Rename didEnterDocument and didLeaveDocument

Rename didEnterDocument & didLeaveDocument to
didAttach & didDetach, as entered* & left* callbacks
has been replaced with attached* & detached* callbacks.
This change will also reflect the type of callback it will
schedule.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181020

[deepak.sa, 2014-08-26 15:52:05]

deepak.sa@samsung.com changed reviewers:
+ dominicc@chromium.org, esprehn@chromium.org

[deepak.sa, 2014-08-26 15:52:05]

PTAL?
Thanks!

[dominicc (has gone to gerrit), 2014-08-27 20:52:33]

On 2014/08/26 15:52:05, deepak.sa wrote:
> PTAL?
> Thanks!

I believe that the spec calls these enteredView and leftView?

http://www.w3.org/TR/custom-elements/#dfn-entered-view-callback

[deepak.sa, 2014-08-28 04:35:43]

On 2014/08/27 20:52:33, dominicc--slow until 9.9 wrote:
> On 2014/08/26 15:52:05, deepak.sa wrote:
> > PTAL?
> > Thanks!
> 
> I believe that the spec calls these enteredView and leftView?
> 
> http://www.w3.org/TR/custom-elements/#dfn-entered-view-callback

Spec has been updated :
http://w3c.github.io/webcomponents/spec/custom/#dfn-attached-callback
And as the follow up of that update, implementation has also been changed (by
you) : https://codereview.chromium.org/117313008

[dominicc (has gone to gerrit), 2014-08-28 05:21:47]

On 2014/08/28 04:35:43, deepak.sa wrote:
> On 2014/08/27 20:52:33, dominicc--slow until 9.9 wrote:
> > On 2014/08/26 15:52:05, deepak.sa wrote:
> > > PTAL?
> > > Thanks!
> > 
> > I believe that the spec calls these enteredView and leftView?
> > 
> > http://www.w3.org/TR/custom-elements/#dfn-entered-view-callback
> 
> Spec has been updated :
> http://w3c.github.io/webcomponents/spec/custom/#dfn-attached-callback
> And as the follow up of that update, implementation has also been changed (by
> you) : https://codereview.chromium.org/117313008

Touche. LGTM.

We should really publish and updated spec.

[dominicc (has gone to gerrit), 2014-08-28 05:21:54]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:22:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/507693003/1

[deepak.sa, 2014-08-28 05:29:23]

Yes, i agree with you. There are lot of changes that has been made to spec. Or
may be we can wait until *valid Name* scenario clears up.

I have to rebase the patch as the last(Append Callback) patch changed the
callback names.

One more thing, i have updated the
w3c/web-platform-tests/custom-elements/testcommon.js and sent a pull request :
https://github.com/w3c/web-platform-tests/pull/1214 . How to add reviewers
there?
Thanks!

[commit-bot: I haz the power, 2014-08-28 05:44:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47428)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/52782)

[commit-bot: I haz the power, 2014-08-28 05:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:45:41]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47436)

[deepak.sa, 2014-08-28 07:05:51]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-08-28 07:06:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/507693003/20001

[commit-bot: I haz the power, 2014-08-28 09:04:51]

Committed patchset #2 (id:20001) as 181020