Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 117313008: Update Custom Elements API to new names. (Closed)

Created:
7 years ago by dominicc (has gone to gerrit)
Modified:
7 years ago
Reviewers:
Hajime Morrita, haraken
CC:
blink-reviews, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Update Custom Elements API to new names. document.register => document.registerElement enteredViewCallback => attachedCallback leftViewCallback => detachedCallback This also removes the long-deprecated webkitRegister method. BUG=180965 R=haraken@chromium.org, morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164213

Patch Set 1 #

Patch Set 2 : Preserve V8HiddenPropertyName alphabetical ordering. #

Patch Set 3 : Update for forgotten tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -195 lines) Patch
M LayoutTests/fast/dom/HTMLTemplateElement/custom-element-wrapper-gc.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/attribute-changed-callback.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/callback-context.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/constructor-calls-created-synchronously.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/created-callback.html View 3 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/custom/default-prototype.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-basic.html View 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-basic-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-constructor.html View 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-namespace.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-namespace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-null-constructor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-null-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-returning-fake.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-returning-fake-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-throwing-constructor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-svg-extends.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-type-extensions.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-type-extensions-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/element-names.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/custom/element-type.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/element-upgrade.html View 4 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/custom/entered-left-document.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/frameElement-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/isolated-world.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/leaks.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-createElement-recursion.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-createElement-reentrancy.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-creation-api.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-innerHTML.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-parser-only.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-parser-script.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/lifecycle-created-paste.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/processing-stack-recursion.html View 6 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-attribute-changed-retrieval.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-callback-recursion.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-register-created-retrieval.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-register-prototype-retrieval.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-register-prototype-retrieval-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-during-upgrade.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-then-register.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-delete-then-register-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-isolation.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-sharing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/resources/document-register-fuzz.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/type-extensions.html View 4 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/custom/unresolved-pseudoclass.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/custom/upgrade-candidate-adopt-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/upgrade-candidate-remove-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/debugger/custom-element-lifecycle-events.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/debugger/custom-element-lifecycle-events-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/custom-elements.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/custom-elements-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M Source/bindings/v8/V8HiddenPropertyName.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackScheduler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackScheduler.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/custom/CustomElementLifecycleCallbacks.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
PTAL
7 years ago (2013-12-20 02:59:44 UTC) #1
haraken
LGTM for bindings/. The name change should be reviewed by morrita-san.
7 years ago (2013-12-20 03:09:33 UTC) #2
Hajime Morrita
lgtm. You can have trybots for browser_tests if you want before landing.
7 years ago (2013-12-20 03:20:26 UTC) #3
dominicc (has gone to gerrit)
On 2013/12/20 03:20:26, morrita1 wrote: > lgtm. You can have trybots for browser_tests if you ...
7 years ago (2013-12-20 04:03:47 UTC) #4
dominicc (has gone to gerrit)
7 years ago (2013-12-20 06:31:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r164213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698