Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/apps/app_url_redirector.cc

Issue 507483003: Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error and propagate rewrites Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/apps/app_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_url_redirector.cc
diff --git a/chrome/browser/apps/app_url_redirector.cc b/chrome/browser/apps/app_url_redirector.cc
index c612651c365db826df2ac5bad021526f620e72ae..968ba278bd79266c7e2d62219e09ff714b8402ce 100644
--- a/chrome/browser/apps/app_url_redirector.cc
+++ b/chrome/browser/apps/app_url_redirector.cc
@@ -57,7 +57,7 @@ bool LaunchAppWithUrl(
// These are guaranteed by CreateThrottleFor below.
DCHECK(!params.is_post());
- DCHECK(UrlHandlers::CanExtensionHandleUrl(app, params.url()));
+ DCHECK(UrlHandlers::CanExtensionHandleUrl(app.get(), params.url()));
Profile* profile =
Profile::FromBrowserContext(source->GetBrowserContext());
@@ -66,7 +66,7 @@ bool LaunchAppWithUrl(
<< params.url().spec() << " -> "
<< app->name() << "(" << app->id() << "):" << handler_id;
apps::LaunchPlatformAppWithUrl(
- profile, app, handler_id, params.url(), params.referrer().url);
+ profile, app.get(), handler_id, params.url(), params.referrer().url);
return true;
}
@@ -112,7 +112,7 @@ AppUrlRedirector::MaybeCreateThrottleFor(net::URLRequest* request,
iter != extensions.end();
++iter) {
const UrlHandlerInfo* handler =
- UrlHandlers::FindMatchingUrlHandler(*iter, request->url());
+ UrlHandlers::FindMatchingUrlHandler(iter->get(), request->url());
if (handler) {
DVLOG(1) << "Found matching app handler for redirection: "
<< (*iter)->name() << "(" << (*iter)->id() << "):"
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/apps/app_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698