Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 507483003: Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile error and propagate rewrites Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/app_url_redirector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 82f8ec4b206008f18ca7372e36086dc6683737d4..54561d1921818d93bce31b42ee969698ce5d398d 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -146,13 +146,13 @@ class ScopedPreviewTestingDelegate : PrintPreviewUI::TestingDelegate {
dialog_size_ = preview_dialog->GetContainerBounds().size();
++rendered_page_count_;
CHECK(rendered_page_count_ <= total_page_count_);
- if (waiting_runner_ && rendered_page_count_ == total_page_count_) {
+ if (waiting_runner_.get() && rendered_page_count_ == total_page_count_) {
waiting_runner_->Quit();
}
}
void WaitUntilPreviewIsReady() {
- CHECK(!waiting_runner_);
+ CHECK(!waiting_runner_.get());
if (rendered_page_count_ < total_page_count_) {
waiting_runner_ = new content::MessageLoopRunner;
waiting_runner_->Run();
« no previous file with comments | « no previous file | chrome/browser/apps/app_url_redirector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698