Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/

chrome/browser/apps/ephemeral_app_launcher.cc

Index: chrome/browser/apps/ephemeral_app_launcher.cc
diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc
index 51b1908b91a73b2fd5491bff6c7948decaa1fcae..7581863473f46c1a11d0caf9857cc7a4c959ae1d 100644
--- a/chrome/browser/apps/ephemeral_app_launcher.cc
+++ b/chrome/browser/apps/ephemeral_app_launcher.cc
@@ -319,7 +319,7 @@ void EphemeralAppLauncher::CheckEphemeralInstallPermitted() {
   install_checker_ = CreateInstallChecker();
   DCHECK(install_checker_.get());
 
-  install_checker_->set_extension(extension);
+  install_checker_->set_extension(extension.get());
   install_checker_->Start(ExtensionInstallChecker::CHECK_BLACKLIST |
                               ExtensionInstallChecker::CHECK_REQUIREMENTS,
                           true,
@@ -404,7 +404,7 @@ bool EphemeralAppLauncher::CheckRequestorPermitted(
 }
 
 void EphemeralAppLauncher::OnManifestParsed() {
-  const Extension* extension = GetLocalizedExtensionForDisplay();
+  const scoped_refptr<Extension> extension = GetLocalizedExtensionForDisplay();

[dcheng, 2014/08/26 00:18:25]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
GetLocalizedExtensionForDisplay() to return a const scoped_refptr<>&
instead--this will help avoid spurious refcount churn for callers that really
don't need to retain a reference. (I can also make this change, but please let
me know if I should or not.)

[benwells, 2014/08/26 05:22:22]

From looking at the impl, it looks like this is right - but unusual for
extensions code which normally uses bare pointers.

   if (!extension) {

[benwells, 2014/08/26 05:22:21]

Does this function need changes so it isn't doing implicit conversions?

Edit: actually this function doesn't compile as is, see bot output.

[dcheng, 2014/08/26 05:28:06]

Yeah, I was fixing it locally since I just noticed this a few minutes ago as
well. Done.

     AbortLaunch(webstore_install::INVALID_MANIFEST, kInvalidManifestError);
     return;