Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/

chrome/browser/apps/ephemeral_app_launcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/ephemeral_app_launcher.h"
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_install_checker.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
@@ skipping 301 matching lines @@
   WebstoreStandaloneInstaller::CompleteInstall(result, error);
 }
 
 void EphemeralAppLauncher::CheckEphemeralInstallPermitted() {
   scoped_refptr<const Extension> extension = GetLocalizedExtensionForDisplay();
   DCHECK(extension.get());  // Checked in OnManifestParsed().
 
   install_checker_ = CreateInstallChecker();
   DCHECK(install_checker_.get());
 
-  install_checker_->set_extension(extension);
+  install_checker_->set_extension(extension.get());
   install_checker_->Start(ExtensionInstallChecker::CHECK_BLACKLIST |
                               ExtensionInstallChecker::CHECK_REQUIREMENTS,
                           true,
                           base::Bind(&EphemeralAppLauncher::OnInstallChecked,
                                      base::Unretained(this)));
 }
 
 void EphemeralAppLauncher::OnInstallChecked(int check_failures) {
   if (!CheckRequestorAlive()) {
     AbortLaunch(webstore_install::OTHER_ERROR, std::string());
@@ skipping 64 matching lines @@
 }
 
 bool EphemeralAppLauncher::CheckRequestorPermitted(
     const base::DictionaryValue& webstore_data,
     std::string* error) const {
   *error = "";
   return true;
 }
 
 void EphemeralAppLauncher::OnManifestParsed() {
-  const Extension* extension = GetLocalizedExtensionForDisplay();
+  const scoped_refptr<Extension> extension = GetLocalizedExtensionForDisplay();

[dcheng, 2014/08/26 00:18:25]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
GetLocalizedExtensionForDisplay() to return a const scoped_refptr<>&
instead--this will help avoid spurious refcount churn for callers that really
don't need to retain a reference. (I can also make this change, but please let
me know if I should or not.)

[benwells, 2014/08/26 05:22:22]

From looking at the impl, it looks like this is right - but unusual for
extensions code which normally uses bare pointers.

   if (!extension) {

[benwells, 2014/08/26 05:22:21]

Does this function need changes so it isn't doing implicit conversions?

Edit: actually this function doesn't compile as is, see bot output.

[dcheng, 2014/08/26 05:28:06]

Yeah, I was fixing it locally since I just noticed this a few minutes ago as
well. Done.

     AbortLaunch(webstore_install::INVALID_MANIFEST, kInvalidManifestError);
     return;
   }
 
   webstore_install::Result result = webstore_install::OTHER_ERROR;
   std::string error;
   if (!CheckCommonLaunchCriteria(profile(), extension, &result, &error)) {
     AbortLaunch(result, error);
     return;
   }
@@ skipping 37 matching lines @@
 
   // CompleteInstall will call Release.
   WebstoreStandaloneInstaller::CompleteInstall(webstore_install::SUCCESS,
                                                std::string());
 }
 
 void EphemeralAppLauncher::ExtensionEnableFlowAborted(bool user_initiated) {
   // CompleteInstall will call Release.
   CompleteInstall(webstore_install::USER_CANCELLED, kUserCancelledError);
 }