chrome/browser/apps/drive/drive_app_converter_browsertest.cc - Issue 507483003: Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_converter_browsertest.cc

Issue 507483003: Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_converter.cc ('k') | chrome/browser/apps/drive/drive_app_provider_browsertest.cc » ('j') | chrome/browser/apps/ephemeral_app_launcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/drive/drive_app_converter_browsertest.cc

diff --git a/chrome/browser/apps/drive/drive_app_converter_browsertest.cc b/chrome/browser/apps/drive/drive_app_converter_browsertest.cc

index ce28ba405262b64d3fb0d57b588c429d86c3b794..9c3f6c2c1114eb97bf22d05ca136020e91150fe9 100644

--- a/chrome/browser/apps/drive/drive_app_converter_browsertest.cc

+++ b/chrome/browser/apps/drive/drive_app_converter_browsertest.cc

@@ -95,7 +95,7 @@ class DriveAppConverterTest : public ExtensionBrowserTest {

private:

void ConverterFinished(const DriveAppConverter* converter, bool success) {

- if (runner_)

+ if (runner_.get())

runner_->Quit();

}