Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 507483003: Remove implicit conversions from scoped_refptr to T* in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index f727059771d28bfc5463624d7d4bf4987e75b410..123b55a1298e2e687b364ab16970f0676c20d1f2 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -146,13 +146,13 @@ class ScopedPreviewTestingDelegate : PrintPreviewUI::TestingDelegate {
dialog_size_ = preview_dialog->GetContainerBounds().size();
++rendered_page_count_;
CHECK(rendered_page_count_ <= total_page_count_);
- if (waiting_runner_ && rendered_page_count_ == total_page_count_) {
+ if (waiting_runner_.get() && rendered_page_count_ == total_page_count_) {
waiting_runner_->Quit();
}
}
void WaitUntilPreviewIsReady() {
- CHECK(!waiting_runner_);
+ CHECK(!waiting_runner_.get());
if (rendered_page_count_ < total_page_count_) {
waiting_runner_ = new content::MessageLoopRunner;
waiting_runner_->Run();
« no previous file with comments | « no previous file | chrome/browser/apps/app_url_redirector.cc » ('j') | chrome/browser/apps/ephemeral_app_launcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698