Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 507373002: MacViews: All targets compile. Fixes unit_tests and message_center_unittests (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20140827-MacViews-WebContentsViewDelegateMac
Project:
chromium
Visibility:
Public.

Description

MacViews: All targets compile. Fixes unit_tests and message_center_unittests This mainly involves adjusting chrome_tests_unit.gypi to exclude chrome's unit_tests that use views UI not enabled by default with toolkit-views=1 on Mac. Mostly the unit tests compile, but fail to link since their corresponding UI parts are not in the browser. (confirm_bubble_views_unittest.cc has a simple compile fix, but isn't linked in yet). An events_test_support dependency is needed in views_test_support for ui/events/test/event_generator which some unit tests use, and otherwise comes in through aura_test_support or views_unittests. BUG=412234, 399191 Committed: https://crrev.com/a9dbe443abce6efe81df9a32b65731fb22f07652 Cr-Commit-Position: refs/heads/master@{#294047}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : Gets most message center tests passing.. but does not really make sense until ported #

Patch Set 5 : Better fix for message_center #

Patch Set 6 : +comment, +gn changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M chrome/browser/ui/views/confirm_bubble_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_unittest.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +30 lines, -1 line 0 comments Download
M ui/message_center/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sky, please take a look.
6 years, 3 months ago (2014-09-09 09:19:24 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-09 15:50:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/507373002/100001
6 years, 3 months ago (2014-09-09 23:25:15 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 94e10eb2911fd93fecff4e9d6ac09d30fce53b87
6 years, 3 months ago (2014-09-10 00:13:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:51 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a9dbe443abce6efe81df9a32b65731fb22f07652
Cr-Commit-Position: refs/heads/master@{#294047}

Powered by Google App Engine
This is Rietveld 408576698