Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Side by Side Diff: ui/message_center/message_center.gyp

Issue 507373002: MacViews: All targets compile. Fixes unit_tests and message_center_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20140827-MacViews-WebContentsViewDelegateMac
Patch Set: +comment, +gn changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 'targets': [ 9 'targets': [
10 { 10 {
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 'msvs_disabled_warnings': [ 4267, ], 112 'msvs_disabled_warnings': [ 4267, ],
113 'conditions': [ 113 'conditions': [
114 # This condition is for Windows 8 Metro mode support. We need to 114 # This condition is for Windows 8 Metro mode support. We need to
115 # specify a particular desktop during widget creation in that case. 115 # specify a particular desktop during widget creation in that case.
116 # This is done using the desktop aura native widget framework. 116 # This is done using the desktop aura native widget framework.
117 ['OS=="win"', { 117 ['OS=="win"', {
118 'dependencies': [ 118 'dependencies': [
119 '../aura/aura.gyp:aura', 119 '../aura/aura.gyp:aura',
120 ], 120 ],
121 }], 121 }],
122 ['toolkit_views==1', { 122 # On Mac, toolkit-views builds still use the Cocoa UI. Keep this in sync
123 # with message_center_unittests below.
124 ['toolkit_views==1 and OS!="mac"', {
123 'dependencies': [ 125 'dependencies': [
124 '../events/events.gyp:events', 126 '../events/events.gyp:events',
125 '../views/views.gyp:views', 127 '../views/views.gyp:views',
126 '../compositor/compositor.gyp:compositor', 128 '../compositor/compositor.gyp:compositor',
127 ], 129 ],
128 }, { 130 }, {
129 'sources/': [ 131 'sources/': [
130 ['exclude', 'views/'], 132 ['exclude', 'views/'],
131 ], 133 ],
132 }], 134 }],
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 'notification_delegate_unittest.cc', 216 'notification_delegate_unittest.cc',
215 'notification_list_unittest.cc', 217 'notification_list_unittest.cc',
216 'test/run_all_unittests.cc', 218 'test/run_all_unittests.cc',
217 ], 219 ],
218 'conditions': [ 220 'conditions': [
219 ['OS=="mac"', { 221 ['OS=="mac"', {
220 'dependencies': [ 222 'dependencies': [
221 '../gfx/gfx.gyp:gfx_test_support', 223 '../gfx/gfx.gyp:gfx_test_support',
222 ], 224 ],
223 }], 225 }],
224 ['toolkit_views==1', { 226 ['toolkit_views==1 and OS!="mac"', {
225 'dependencies': [ 227 'dependencies': [
226 # Compositor is needed by message_center_view_unittest.cc 228 # Compositor is needed by message_center_view_unittest.cc
227 # and for the fonts used by bounded_label_unittest.cc. 229 # and for the fonts used by bounded_label_unittest.cc.
228 '../compositor/compositor.gyp:compositor', 230 '../compositor/compositor.gyp:compositor',
229 '../views/views.gyp:views', 231 '../views/views.gyp:views',
230 '../views/views.gyp:views_test_support', 232 '../views/views.gyp:views_test_support',
231 ], 233 ],
232 'sources': [ 234 'sources': [
233 'views/bounded_label_unittest.cc', 235 'views/bounded_label_unittest.cc',
234 'views/message_center_view_unittest.cc', 236 'views/message_center_view_unittest.cc',
(...skipping 12 matching lines...) Expand all
247 # See http://crbug.com/162998#c4 for why this is needed. 249 # See http://crbug.com/162998#c4 for why this is needed.
248 ['OS=="linux" and use_allocator!="none"', { 250 ['OS=="linux" and use_allocator!="none"', {
249 'dependencies': [ 251 'dependencies': [
250 '../../base/allocator/allocator.gyp:allocator', 252 '../../base/allocator/allocator.gyp:allocator',
251 ], 253 ],
252 }], 254 }],
253 ], 255 ],
254 }, # target_name: message_center_unittests 256 }, # target_name: message_center_unittests
255 ], 257 ],
256 } 258 }
OLDNEW
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698