mojo/services/gles2/command_buffer_type_conversions.h - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/gles2/command_buffer_type_conversions.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile for real Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl ('k') | mojo/services/gles2/command_buffer_type_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/gles2/command_buffer_type_conversions.h

diff --git a/mojo/services/gles2/command_buffer_type_conversions.h b/mojo/services/gles2/command_buffer_type_conversions.h

index b2334d008ac03d889a2929aae989118f29cc0b2f..2579681c7d672dfa10213c3213c33c41eb70caa4 100644

--- a/mojo/services/gles2/command_buffer_type_conversions.h

+++ b/mojo/services/gles2/command_buffer_type_conversions.h

@@ -14,12 +14,13 @@ namespace mojo {

class CommandBufferState;

template <>

-class TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State> {

- public:

- static CommandBufferStatePtr ConvertFrom(

- const gpu::CommandBuffer::State& input);

- static gpu::CommandBuffer::State ConvertTo(

- const CommandBufferStatePtr& input);

+struct TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State> {

+ static CommandBufferStatePtr Convert(const gpu::CommandBuffer::State& input);

+};

+template <>

+struct TypeConverter<gpu::CommandBuffer::State, CommandBufferStatePtr> {

+ static gpu::CommandBuffer::State Convert(const CommandBufferStatePtr& input);

};

} // namespace mojo