mojo/services/gles2/command_buffer_type_conversions.cc - Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/gles2/command_buffer_type_conversions.cc

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile for real Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/gles2/command_buffer_type_conversions.h ('k') | mojo/services/html_viewer/blink_input_events_type_converters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/gles2/command_buffer_type_conversions.cc

diff --git a/mojo/services/gles2/command_buffer_type_conversions.cc b/mojo/services/gles2/command_buffer_type_conversions.cc

index 3952bef3179688b4a9407c092d650bca2e35a3e8..a144f8884f9228ec083353631a9d3dc7813d1cea 100644

--- a/mojo/services/gles2/command_buffer_type_conversions.cc

+++ b/mojo/services/gles2/command_buffer_type_conversions.cc

@@ -9,7 +9,7 @@

namespace mojo {

CommandBufferStatePtr

-TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State>::ConvertFrom(

+TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State>::Convert(

const gpu::CommandBuffer::State& input) {

CommandBufferStatePtr result(CommandBufferState::New());

result->num_entries = input.num_entries;

@@ -23,7 +23,7 @@ TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State>::ConvertFrom(

}

gpu::CommandBuffer::State

-TypeConverter<CommandBufferStatePtr, gpu::CommandBuffer::State>::ConvertTo(

+TypeConverter<gpu::CommandBuffer::State, CommandBufferStatePtr>::Convert(

const CommandBufferStatePtr& input) {

gpu::CommandBuffer::State state;

state.num_entries = input->num_entries;