Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: mojo/common/common_type_converters.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile for real Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/serial/serial_connection.cc ('k') | mojo/common/common_type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/common_type_converters.h
diff --git a/mojo/common/common_type_converters.h b/mojo/common/common_type_converters.h
index 9afbfc63112c82c6e3d475a97588186369c24e70..159325e025fc7dacd2baac066f3a56bd2e989a3b 100644
--- a/mojo/common/common_type_converters.h
+++ b/mojo/common/common_type_converters.h
@@ -16,24 +16,33 @@ class GURL;
namespace mojo {
template <>
-class MOJO_COMMON_EXPORT TypeConverter<String, base::StringPiece> {
- public:
- static String ConvertFrom(const base::StringPiece& input);
- static base::StringPiece ConvertTo(const String& input);
+struct MOJO_COMMON_EXPORT TypeConverter<String, base::StringPiece> {
+ static String Convert(const base::StringPiece& input);
};
template <>
-class MOJO_COMMON_EXPORT TypeConverter<String, base::string16> {
- public:
- static String ConvertFrom(const base::string16& input);
- static base::string16 ConvertTo(const String& input);
+struct MOJO_COMMON_EXPORT TypeConverter<base::StringPiece, String> {
+ static base::StringPiece Convert(const String& input);
};
template <>
-class MOJO_COMMON_EXPORT TypeConverter<String, GURL> {
- public:
- static String ConvertFrom(const GURL& input);
- static GURL ConvertTo(const String& input);
+struct MOJO_COMMON_EXPORT TypeConverter<String, base::string16> {
+ static String Convert(const base::string16& input);
+};
+
+template <>
+struct MOJO_COMMON_EXPORT TypeConverter<base::string16, String> {
+ static base::string16 Convert(const String& input);
+};
+
+template <>
+struct MOJO_COMMON_EXPORT TypeConverter<String, GURL> {
+ static String Convert(const GURL& input);
+};
+
+template <>
+struct MOJO_COMMON_EXPORT TypeConverter<GURL, String> {
+ static GURL Convert(const String& input);
};
} // namespace mojo
« no previous file with comments | « extensions/browser/api/serial/serial_connection.cc ('k') | mojo/common/common_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698