Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: mojo/common/common_type_converters.h

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile for real Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_ 5 #ifndef MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_
6 #define MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_ 6 #define MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_
7 7
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/string_piece.h" 9 #include "base/strings/string_piece.h"
10 #include "mojo/common/mojo_common_export.h" 10 #include "mojo/common/mojo_common_export.h"
11 #include "mojo/public/cpp/bindings/string.h" 11 #include "mojo/public/cpp/bindings/string.h"
12 #include "mojo/public/cpp/bindings/type_converter.h" 12 #include "mojo/public/cpp/bindings/type_converter.h"
13 13
14 class GURL; 14 class GURL;
15 15
16 namespace mojo { 16 namespace mojo {
17 17
18 template <> 18 template <>
19 class MOJO_COMMON_EXPORT TypeConverter<String, base::StringPiece> { 19 struct MOJO_COMMON_EXPORT TypeConverter<String, base::StringPiece> {
20 public: 20 static String Convert(const base::StringPiece& input);
21 static String ConvertFrom(const base::StringPiece& input);
22 static base::StringPiece ConvertTo(const String& input);
23 }; 21 };
24 22
25 template <> 23 template <>
26 class MOJO_COMMON_EXPORT TypeConverter<String, base::string16> { 24 struct MOJO_COMMON_EXPORT TypeConverter<base::StringPiece, String> {
27 public: 25 static base::StringPiece Convert(const String& input);
28 static String ConvertFrom(const base::string16& input);
29 static base::string16 ConvertTo(const String& input);
30 }; 26 };
31 27
32 template <> 28 template <>
33 class MOJO_COMMON_EXPORT TypeConverter<String, GURL> { 29 struct MOJO_COMMON_EXPORT TypeConverter<String, base::string16> {
34 public: 30 static String Convert(const base::string16& input);
35 static String ConvertFrom(const GURL& input); 31 };
36 static GURL ConvertTo(const String& input); 32
33 template <>
34 struct MOJO_COMMON_EXPORT TypeConverter<base::string16, String> {
35 static base::string16 Convert(const String& input);
36 };
37
38 template <>
39 struct MOJO_COMMON_EXPORT TypeConverter<String, GURL> {
40 static String Convert(const GURL& input);
41 };
42
43 template <>
44 struct MOJO_COMMON_EXPORT TypeConverter<GURL, String> {
45 static GURL Convert(const String& input);
37 }; 46 };
38 47
39 } // namespace mojo 48 } // namespace mojo
40 49
41 #endif // MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_ 50 #endif // MOJO_COMMON_COMMON_TYPE_CONVERTERS_H_
OLDNEW
« no previous file with comments | « extensions/browser/api/serial/serial_connection.cc ('k') | mojo/common/common_type_converters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698