Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: extensions/browser/api/serial/serial_connection.cc

Issue 507173003: Change TypeConverter<X,Y>::ConvertFrom and ConvertTo into a single symmetric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile for real Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/serial/serial_connection.h ('k') | mojo/common/common_type_converters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/serial/serial_connection.cc
diff --git a/extensions/browser/api/serial/serial_connection.cc b/extensions/browser/api/serial/serial_connection.cc
index a81def2b3f7f3ccfaf717d133209764aa77e777c..cfdcc760b29fa4943755c01ede6846e98f4726ce 100644
--- a/extensions/browser/api/serial/serial_connection.cc
+++ b/extensions/browser/api/serial/serial_connection.cc
@@ -401,7 +401,7 @@ namespace mojo {
device::serial::HostControlSignalsPtr
TypeConverter<device::serial::HostControlSignalsPtr,
extensions::core_api::serial::HostControlSignals>::
- ConvertFrom(const extensions::core_api::serial::HostControlSignals& input) {
+ Convert(const extensions::core_api::serial::HostControlSignals& input) {
device::serial::HostControlSignalsPtr output(
device::serial::HostControlSignals::New());
if (input.dtr.get()) {
@@ -419,7 +419,7 @@ TypeConverter<device::serial::HostControlSignalsPtr,
device::serial::ConnectionOptionsPtr
TypeConverter<device::serial::ConnectionOptionsPtr,
extensions::core_api::serial::ConnectionOptions>::
- ConvertFrom(const extensions::core_api::serial::ConnectionOptions& input) {
+ Convert(const extensions::core_api::serial::ConnectionOptions& input) {
device::serial::ConnectionOptionsPtr output(
device::serial::ConnectionOptions::New());
if (input.bitrate.get() && *input.bitrate > 0)
« no previous file with comments | « extensions/browser/api/serial/serial_connection.h ('k') | mojo/common/common_type_converters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698