Issue 507153002: Make ICU C++ 11 compliant on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507153002: Make ICU C++ 11 compliant on Windows (Closed)

Created:
6 years, 3 months ago by jungshik at Google

Modified:
6 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

Make ICU C++ 11 compliant on Windows i18n/winmfmt.* has a few warnings emitted when compiled with clang on Windows due to the following issue: ISO C++11 does not allow conversion from string literal to 'wchar_t *' [-Wwritable-strings] This CL from thakis@ takes care of it. An upstream bug was filed : http://bugs.icu-project.org/trac/ticket/11102 BUG=82385 TEST=Build on Windows with clang and the above warning is not emitted while building ICU. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291660

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -2 lines)			Patch
M	README.chromium	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	patches/clang_win.patch	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	source/i18n/winnmfmt.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/i18n/winnmfmt.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

jshin@chromium.org changed reviewers: + thakis@chromium.org

6 years, 3 months ago (2014-08-26 22:24:25 UTC) #1

jungshik at Google

6 years, 3 months ago (2014-08-26 22:44:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r291660 (presubmit successful).

Expand Messages | Collapse Messages