Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: README.chromium

Issue 507153002: Make ICU C++ 11 compliant on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | patches/clang_win.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: icu 1 Name: icu
2 URL: http://site.icu-project.org/ 2 URL: http://site.icu-project.org/
3 Version: 52.1 3 Version: 52.1
4 License: MIT 4 License: MIT
5 Security Critical: yes 5 Security Critical: yes
6 6
7 Description: 7 Description:
8 This directory contains the source code of ICU 52.1 for C/C++ 8 This directory contains the source code of ICU 52.1 for C/C++
9 9
10 1. It was obtained with the following: 10 1. It was obtained with the following:
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 upstream bug: http://bugs.icu-project.org/trac/ticket/10486 156 upstream bug: http://bugs.icu-project.org/trac/ticket/10486
157 fixed in ICU 53) 157 fixed in ICU 53)
158 d. Explicitly use Windows 'A' API when argument is an LPSTR in wintz.c 158 d. Explicitly use Windows 'A' API when argument is an LPSTR in wintz.c
159 upstream bug : http://bugs.icu-project.org/trac/ticket/10870 159 upstream bug : http://bugs.icu-project.org/trac/ticket/10870
160 160
161 - patches/data.build.patch : 161 - patches/data.build.patch :
162 Remove unnecessary resources : invuca, unames, collator source, stringprep 162 Remove unnecessary resources : invuca, unames, collator source, stringprep
163 - patches/data.build.win.patch : 163 - patches/data.build.win.patch :
164 Windows-only data build patch. 164 Windows-only data build patch.
165 165
166 - patches/clang_win.patch :
167 Take care of 3 warnings from clang and MSVC 2013.
168 upstream bug : http://bugs.icu-project.org/trac/ticket/11102
169
166 9. Pre-built data files are checked in with the following steps on Linux: 170 9. Pre-built data files are checked in with the following steps on Linux:
167 171
168 a. Make a icu data build directory outside the Chromium source tree 172 a. Make a icu data build directory outside the Chromium source tree
169 and cd to that directory. 173 and cd to that directory.
170 b. Run 174 b. Run
171 175
172 ${CHROME_ICU_TREE_TOP}/source/runConfigureICU Linux --disable-layout 176 ${CHROME_ICU_TREE_TOP}/source/runConfigureICU Linux --disable-layout
173 177
174 c. Run 'make' 178 c. Run 'make'
175 d. 'make' will fail in the 1st pass. Copy 179 d. 'make' will fail in the 1st pass. Copy
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 c. In Visual Studio, open source/allinone/allinone.sln solution 224 c. In Visual Studio, open source/allinone/allinone.sln solution
221 in ${SEPARATE_ICU_ROOT} 225 in ${SEPARATE_ICU_ROOT}
222 d. Build 'makedata' target 226 d. Build 'makedata' target
223 e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin 227 e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
224 f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll 228 f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
225 and check that in. 229 and check that in.
226 230
227 231
228 10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT. 232 10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT.
229 - patches/declspec.patch 233 - patches/declspec.patch
OLDNEW
« no previous file with comments | « no previous file | patches/clang_win.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698