Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 461443003: Account for DIP when setting the preferred size for tab capture. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Account for DIP when setting the preferred size for tab capture. This is an optimization for systems where there is more than one physical pixel per logical pixel (e.g., Chromebook Pixel, Mac Retina). On these systems, the render widget should be "preferably" sized such that its physical size will match that of the tab capture frame size. Because the entire graphics pipeline is handling N^2 less data, and also will no longer need to down-scale images, users should see huge tab capture performance improvements (e.g., higher frame rates, lower CPU utilization and fan noise). Expected side effect: Fullscreen-Within-Tab widgets will appear shrunk. However, since content renderers are still DIP-aware, any UI controls within the widget will appear right-sized. In other words, user interaction will not be diminished by this change. Testing: Confirmed Fullscreen-Within-Tab and tab capture output is correct by varying --force-device-scale-factor=X. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289040

Patch Set 1 #

Patch Set 2 : Add gfx::Screen and gfx::Display fakes for unit test runs on non-Mac platforms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -3 lines) Patch
M content/browser/media/capture/web_contents_video_capture_device.cc View 5 chunks +43 lines, -3 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 8 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
miu
hclam: PTAL.
6 years, 4 months ago (2014-08-11 00:13:01 UTC) #1
Alpha Left Google
lgtm
6 years, 4 months ago (2014-08-11 17:25:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/461443003/1
6 years, 4 months ago (2014-08-11 17:26:57 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 00:57:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 01:43:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3104) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/5185)
6 years, 4 months ago (2014-08-12 01:43:44 UTC) #6
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-12 03:32:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/461443003/20001
6 years, 4 months ago (2014-08-12 03:34:41 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 07:36:15 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 10:18:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5809)
6 years, 4 months ago (2014-08-12 10:18:58 UTC) #11
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-12 16:34:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/461443003/20001
6 years, 4 months ago (2014-08-12 16:36:51 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 18:50:46 UTC) #14
Message was sent while issue was closed.
Change committed as 289040

Powered by Google App Engine
This is Rietveld 408576698