device/serial/data_sink_receiver.cc - Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/data_sink_receiver.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Regenerate Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/serial/data_sink_receiver.cc

diff --git a/device/serial/data_sink_receiver.cc b/device/serial/data_sink_receiver.cc

index ede0468c6cfd156f96c885cf4a03a91199bd25cf..7e3834e4c504f6698494d27da0203d534c4c23d4 100644

--- a/device/serial/data_sink_receiver.cc

+++ b/device/serial/data_sink_receiver.cc

@@ -241,7 +241,7 @@ DataSinkReceiver::Buffer::Buffer(scoped_refptr<DataSinkReceiver> receiver,

}

DataSinkReceiver::Buffer::~Buffer() {

- if (!receiver_)

+ if (!receiver_.get())

return;

if (cancelled_)

receiver_->DoneWithError(0, cancellation_error_);

« no previous file with comments | « device/hid/hid_connection_unittest.cc ('k') | device/serial/data_sink_unittest.cc » ('j') | no next file with comments »