device/hid/hid_connection_unittest.cc - Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_connection_unittest.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Regenerate Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/hid/hid_connection_unittest.cc

diff --git a/device/hid/hid_connection_unittest.cc b/device/hid/hid_connection_unittest.cc

index e5f215fbcf23f5fbabbd71b57a7cf971c9eab324..aade928171bd891d0dd40f5ae0c6d5c19aeb4534 100644

--- a/device/hid/hid_connection_unittest.cc

+++ b/device/hid/hid_connection_unittest.cc

@@ -127,7 +127,7 @@ TEST_F(HidConnectionTest, ReadWrite) {

if (!UsbTestGadget::IsTestEnabled()) return;

scoped_refptr<HidConnection> conn = service_->Connect(device_id_);

- ASSERT_TRUE(conn);

+ ASSERT_TRUE(conn.get());

for (int i = 0; i < 8; ++i) {

scoped_refptr<IOBufferWithSize> buffer(new IOBufferWithSize(9));

« no previous file with comments | « device/bluetooth/bluetooth_socket_thread.cc ('k') | device/serial/data_sink_receiver.cc » ('j') | no next file with comments »