Issue 507038: Shut down fontconfig in test_shell to lower the amount of memory leaked in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 507038: Shut down fontconfig in test_shell to lower the amount of memory leaked in... (Closed)

Created:
11 years ago by plz use chromium.org account

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, dank, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Shut down fontconfig in test_shell to lower the amount of memory leaked in fontconfig. The remaining leaks are due to static variables in pango holding references to fontconfig data structures. These should go away for a more up to date version of pango. BUG=9245 TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes Patch by Jochen Eisinger <eisinger@google.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34945

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/tools/test_shell/test_shell_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM (looks like you didn't push "Publish+Mail Comments" link).

11 years ago (2009-12-18 09:57:41 UTC) #1

plz use chromium.org account

11 years ago (2009-12-18 14:52:05 UTC) #3

See http://codereview.chromium.org/502072 for an updated cl that fixes the issue
with valgrind and test_shell_tests

Expand Messages | Collapse Messages