Issue 502072: Put the fontconfig FcFini call in the PlatformShutdown() method instead of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502072: Put the fontconfig FcFini call in the PlatformShutdown() method instead of... (Closed)

Created:
11 years ago by plz use chromium.org account

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Put the fontconfig FcFini call in the PlatformShutdown() method instead of PlatformCleanUp(). The latter is called multiple times, which results in fontconfig being shutdown too early. Fixes buildbot failure introduced in revision 34945. BUG=9245 TEST=Run test_shell using valgrind. Memory leaks related to fontconfig should drop from around 138079 bytes to around 24573 bytes. Also use valgrind to check for invalid reads. Patch from Jochen Eisinger <eisinger@google.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34961

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/test_shell/test_shell_gtk.cc	View		2 chunks	+1 line, -1 line	0 comments	Download