chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc - Issue 506883003: Remove implicit conversions from scoped_refptr to T* in chrome/*/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

Issue 506883003: Remove implicit conversions from scoped_refptr to T* in chrome/*/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

index da5ad3a1c0137807fa4d84b0b9f5e45d5abe5b8a..3228b4467c7aa33a7c208d2d796ba6a55b27866b 100644

--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

@@ -62,7 +62,7 @@ TEST_F(UIOverrideTest, ParseManifest) {

*static_cast<base::DictionaryValue*>(root.get()),

Extension::NO_FLAGS,

&error);

- ASSERT_TRUE(extension) << error;

+ ASSERT_TRUE(extension.get()) << error;

ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kUIOverride));

UIOverrides* ui_override = static_cast<UIOverrides*>(

@@ -91,7 +91,7 @@ TEST_F(UIOverrideTest, ParseBrokenManifest) {

*static_cast<base::DictionaryValue*>(root.get()),

Extension::NO_FLAGS,

&error);

- EXPECT_FALSE(extension);

+ EXPECT_FALSE(extension.get());

EXPECT_EQ(

extensions::ErrorUtils::FormatErrorMessage(

extensions::manifest_errors::kInvalidEmptyDictionary,