Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

Issue 506883003: Remove implicit conversions from scoped_refptr to T* in chrome/*/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
index 1acf3f0fb62c4ca27871e11a00b2efbf46b09df7..138e02d2d1e422c734d7d7a798baed4fca6f750d 100644
--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
@@ -85,7 +85,7 @@ TEST_F(OverrideSettingsTest, ParseManifest) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
#if defined(OS_WIN)
ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
@@ -128,7 +128,7 @@ TEST_F(OverrideSettingsTest, ParsePrepopulatedId) {
*static_cast<base::DictionaryValue*>(root.get()),
Extension::NO_FLAGS,
&error);
- ASSERT_TRUE(extension);
+ ASSERT_TRUE(extension.get());
#if defined(OS_WIN)
ASSERT_TRUE(extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
@@ -169,7 +169,7 @@ TEST_F(OverrideSettingsTest, ParseBrokenManifest) {
extensions::manifest_keys::kSettingsOverride),
error);
#else
- EXPECT_TRUE(extension);
+ EXPECT_TRUE(extension.get());
EXPECT_FALSE(
extension->manifest()->HasPath(manifest_keys::kSettingsOverride));
#endif

Powered by Google App Engine
This is Rietveld 408576698