Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 506803004: gfx: Don't template gfx::Rect and gfx::RectF (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, oshima, piman, clholgat, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gfx: Don't template gfx::Rect and gfx::RectF The extern template class declaration prevents the compiler from ever inlining methods even when they are in the .h file and it makes sense to do so. Stop templating the classes to remove the extern template class and allow the compiler to make better decisions about inlining. Performance numbers are at https://crbug.com/407444#c13 This drops up to 200us off our total thread times per frame. It also decreases the size of the android binary as shown in the https://crbug.com/407444#c12 by 3613 bytes before even removing the RectBase class from the build. This also makes finding and reading the public API for Rect and RectF classes much easier for developers. BUG=407444 Committed: https://crrev.com/a5cc021b6ee19af6a931db1042ec2ab562506010 Cr-Commit-Position: refs/heads/master@{#299771}

Patch Set 1 : inlines: . #

Patch Set 2 : inlines: rebase #

Patch Set 3 : inlines: rm-rectbase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -591 lines) Patch
M ui/gfx/geometry/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/geometry/rect.h View 5 chunks +131 lines, -21 lines 0 comments Download
M ui/gfx/geometry/rect.cc View 2 chunks +195 lines, -11 lines 0 comments Download
D ui/gfx/geometry/rect_base.h View 1 2 1 chunk +0 lines, -174 lines 0 comments Download
D ui/gfx/geometry/rect_base_impl.h View 1 2 1 chunk +0 lines, -354 lines 0 comments Download
M ui/gfx/geometry/rect_f.h View 4 chunks +130 lines, -23 lines 0 comments Download
M ui/gfx/geometry/rect_f.cc View 1 chunk +190 lines, -4 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danakj
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 22:01:17 UTC) #1
danakj
6 years, 2 months ago (2014-10-15 19:49:46 UTC) #3
sky
LGTM
6 years, 2 months ago (2014-10-15 20:19:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/506803004/60001
6 years, 2 months ago (2014-10-15 20:46:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/506803004/60001
6 years, 2 months ago (2014-10-15 20:47:24 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-15 21:28:02 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:28:50 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a5cc021b6ee19af6a931db1042ec2ab562506010
Cr-Commit-Position: refs/heads/master@{#299771}

Powered by Google App Engine
This is Rietveld 408576698