Remove implicit conversions from scoped_refptr to T* in chrome/renderer/

Remove implicit conversions from scoped_refptr to T* in chrome/renderer/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
Committed: https://crrev.com/b7f9ea253737d6f226a534d4ee851389372f07b4
Cr-Commit-Position: refs/heads/master@{#292509}

[dcheng, 2014-08-25 23:49:48]

dcheng@chromium.org changed reviewers:
+ jhawkins@chromium.org

[dcheng, 2014-08-25 23:50:18]

(Resending with missing blurb)

Unfortunately, we can't make scoped_refptr testable until the conversion
operator has been removed. While it would be possible to disable the conversion
operator and make it testable in the same patch, the automated tool tries to
skip rewriting code where manual cleanups would be useful. This includes things
like:

// What if ReturnsScopedRefPtr() creates a new object internally?
if (ReturnsScopedRefPtr())

Foo* Bar() {
  const scoped_refptr<Foo>& f = ReturnsScopedRefPtr();
  return f;  // Does the return type need to be rewritten? Or is .get() safe?
}

Doing this in one patch would make catching some of these instances (in
particular, a boolean test on a temporary scoped_refptr) more difficult. As a
result, the work is being split into several steps:
Step 1: Rewrite all implicit conversions to be explicit (or rewrite the receiver
type to scoped_refptr<T>, if the tool believes the conversion to be unsafe).
Step 2: Once a platform compiles cleanly without the conversion operator, #ifdef
the conversion operator out.
Step 3: Make scoped_refptr testable on that platform.
Step 4: Remove unnecessary calls to .get().

[dcheng, 2014-08-28 16:27:34]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2014-08-28 16:27:34]

+thakis, mind taking a look, as jhawkins seems to be busy?

[Nico, 2014-08-28 16:32:18]

lgtm

[dcheng, 2014-08-28 16:35:02]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:36:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506773002/1

[commit-bot: I haz the power, 2014-08-28 16:41:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-08-28 16:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:42:59]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[dcheng, 2014-08-28 16:45:24]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:46:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506773002/20001

[commit-bot: I haz the power, 2014-08-28 18:22:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 18:54:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 18:54:24]

Failed to apply patch for
chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc:69
  error:
chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc:
patch does not apply

Patch:      
chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
Index:
chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
diff --git
a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
index
6ceb9c62c9532e3cbf3871d1310ea5384c0140b4..3504d5d752a02cd0975556a5a4b971479587dd11
100644
---
a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
+++
b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
@@ -69,13 +69,13 @@ TEST_F(RendererPermissionsPolicyDelegateTest,
CannotScriptSigninProcess) {
   std::string error;
 
   EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
-      extension, kSigninUrl, kSigninUrl, -1, -1, &error))
+      extension.get(), kSigninUrl, kSigninUrl, -1, -1, &error))
       << error;
   // Pretend we are in the signin process. We should not be able to execute
   // script.
   CommandLine::ForCurrentProcess()->AppendSwitch(switches::kSigninProcess);
   EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
-      extension, kSigninUrl, kSigninUrl, -1, -1, &error))
+      extension.get(), kSigninUrl, kSigninUrl, -1, -1, &error))
       << error;
 }
 
@@ -87,7 +87,7 @@ TEST_F(RendererPermissionsPolicyDelegateTest,
CannotScriptWebstore) {
   std::string error;
 
   EXPECT_TRUE(extension->permissions_data()->CanAccessPage(
-      extension, kAnyUrl, kAnyUrl, -1, -1, &error))
+      extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))
       << error;
 
   // Pretend we are in the webstore process. We should not be able to execute
@@ -97,7 +97,7 @@ TEST_F(RendererPermissionsPolicyDelegateTest,
CannotScriptWebstore) {
   extension_dispatcher_->OnLoadedInternal(webstore_extension);
   extension_dispatcher_->OnActivateExtension(extension_misc::kWebStoreAppId);
   EXPECT_FALSE(extension->permissions_data()->CanAccessPage(
-      extension, kAnyUrl, kAnyUrl, -1, -1, &error))
+      extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))
       << error;
 }

[dcheng, 2014-08-28 22:59:51]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 23:01:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506773002/40001

[commit-bot: I haz the power, 2014-08-29 00:00:18]

Committed patchset #3 (id:40001) as 1aedd0cd97dc3426560f11a2d4ceb4acaf68c2c8

[commit-bot: I haz the power, 2014-09-10 03:03:57]

Patchset 3 (id:??) landed as
https://crrev.com/b7f9ea253737d6f226a534d4ee851389372f07b4
Cr-Commit-Position: refs/heads/master@{#292509}