Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: chrome/renderer/media/webrtc_logging_message_filter.cc

Issue 506773002: Remove implicit conversions from scoped_refptr to T* in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/media/cast_session_delegate.cc ('k') | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/media/webrtc_logging_message_filter.cc
diff --git a/chrome/renderer/media/webrtc_logging_message_filter.cc b/chrome/renderer/media/webrtc_logging_message_filter.cc
index 8177aea90c1195f18128b26719a42ccad08c141c..4669df0a2dadd8cc3e186219c9371e8998e5fad6 100644
--- a/chrome/renderer/media/webrtc_logging_message_filter.cc
+++ b/chrome/renderer/media/webrtc_logging_message_filter.cc
@@ -16,7 +16,7 @@ WebRtcLoggingMessageFilter::WebRtcLoggingMessageFilter(
log_message_delegate_(NULL),
sender_(NULL) {
// May be null in a browsertest using MockRenderThread.
- if (io_message_loop_) {
+ if (io_message_loop_.get()) {
io_message_loop_->PostTask(
FROM_HERE, base::Bind(
&WebRtcLoggingMessageFilter::CreateLoggingHandler,
@@ -40,18 +40,18 @@ bool WebRtcLoggingMessageFilter::OnMessageReceived(
}
void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Sender* sender) {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
sender_ = sender;
}
void WebRtcLoggingMessageFilter::OnFilterRemoved() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
sender_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
void WebRtcLoggingMessageFilter::OnChannelClosing() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
sender_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
@@ -63,28 +63,28 @@ void WebRtcLoggingMessageFilter::AddLogMessages(
}
void WebRtcLoggingMessageFilter::LoggingStopped() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
Send(new WebRtcLoggingMsg_LoggingStopped());
}
void WebRtcLoggingMessageFilter::CreateLoggingHandler() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
log_message_delegate_ =
new ChromeWebRtcLogMessageDelegate(io_message_loop_, this);
}
void WebRtcLoggingMessageFilter::OnStartLogging() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
log_message_delegate_->OnStartLogging();
}
void WebRtcLoggingMessageFilter::OnStopLogging() {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
log_message_delegate_->OnStopLogging();
}
void WebRtcLoggingMessageFilter::Send(IPC::Message* message) {
- DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
+ DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread());
if (!sender_) {
DLOG(ERROR) << "IPC sender not available.";
delete message;
« no previous file with comments | « chrome/renderer/media/cast_session_delegate.cc ('k') | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698