chrome/browser/policy/configuration_policy_handler_list_factory.cc - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_handler_list_factory.cc

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MetricsReporting handling moved to browser_options_handler. JS callback is not called if the… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/metrics/metrics_reporting_state.cc ('k') | chrome/browser/resources/options/browser_options.html » ('j') | chrome/browser/ui/webui/options/browser_options_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_handler_list_factory.cc

diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc

index 3c856523039915acad9d931d767c481627024456..4e826a46dde22af0ecdce81abcb8cf642f76e699 100644

--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc

+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc

@@ -101,9 +101,6 @@ const PolicyToPreferenceMapEntry kSimplePolicyMap[] = {

{ key::kPrintingEnabled,

prefs::kPrintingEnabled,

base::Value::TYPE_BOOLEAN },

- { key::kMetricsReportingEnabled,

- prefs::kMetricsReportingEnabled,

- base::Value::TYPE_BOOLEAN },

{ key::kApplicationLocaleValue,

prefs::kApplicationLocale,

base::Value::TYPE_STRING },