chrome/browser/ui/webui/options/browser_options_handler.h - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MetricsReporting handling moved to browser_options_handler. JS callback is not called if the… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_reporting_state.cc ('K') | « chrome/browser/ui/views/session_crashed_bubble_view.cc ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/browser_options_handler.h

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.h b/chrome/browser/ui/webui/options/browser_options_handler.h

index 0c65c886ea4dd38974e0f89c2597059f3c4b72bf..89c2c017b72889b3738694eb85808b6652bbffae 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.h

+++ b/chrome/browser/ui/webui/options/browser_options_handler.h

@@ -327,6 +327,15 @@ class BrowserOptionsHandler

// Setup the UI for showing which settings are extension controlled.

void SetupExtensionControlledIndicators();

+ // Setup the value and the disabled property for metrics reporting.

+ void SetupMetricsReportingCheckbox();

+ // Passes forward the request to change MetricsReportingEnabled.

Alexei Svitkine (slow) 2014/09/05 20:50:25 Nit: I suggest using a comment similar to the one

gayane -on leave until 09-2017 2014/09/08 18:32:46 Done.

+ void HandleMetricsReportingChange(const base::ListValue* args);

+ // Notifies the result of MetricsReportingEnabled change to Javascript layer.

+ void MetricsReportingChangeCallback(bool success);

#if defined(OS_CHROMEOS)

// Setup the accessibility features for ChromeOS.

void SetupAccessibilityFeatures();