chrome/browser/extensions/api/preference/preference_api.cc - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: access to prefs moved from browser_options_handle to metrics_reposting_state Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/settings/device_settings_provider.cc ('K') | « chrome/browser/chromeos/settings/device_settings_provider.cc ('k') | chrome/browser/metrics/chrome_metrics_service_accessor.h » ('j') | chrome/browser/metrics/metrics_reporting_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_api.cc

diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc

index 68f0d7c8220302393edfe24e03ff2cb43964d98b..3af9a2f84ae07be7771026ad7c2ab5342eade901 100644

--- a/chrome/browser/extensions/api/preference/preference_api.cc

+++ b/chrome/browser/extensions/api/preference/preference_api.cc

@@ -96,6 +96,8 @@ PrefMappingEntry kPrefMapping[] = {

APIPermission::kPrivacy, APIPermission::kPrivacy},

{"translationServiceEnabled", prefs::kEnableTranslate,

APIPermission::kPrivacy, APIPermission::kPrivacy},

+ {"metricsReportingEnabled", prefs::kMetricsReportingEnabled,

+ APIPermission::kPrivacy, APIPermission::kPrivacy},

#if defined(OS_CHROMEOS)

{"autoclick", prefs::kAccessibilityAutoclickEnabled,

APIPermission::kAccessibilityFeaturesRead,