chrome/browser/chromeos/settings/device_settings_provider.cc - Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: access to prefs moved from browser_options_handle to metrics_reposting_state Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/wizard_controller.cc ('K') | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chrome/browser/extensions/api/preference/preference_api.cc » ('j') | chrome/browser/metrics/metrics_reporting_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_provider.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_provider.cc b/chrome/browser/chromeos/settings/device_settings_provider.cc

index 3b2b3f318b02f1d92a6a22e9d0e40e4f6ee2dc85..7894f698a765ec7a553c6e5d038a471b3326e8c1 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider.cc

+++ b/chrome/browser/chromeos/settings/device_settings_provider.cc

@@ -848,7 +848,8 @@ void DeviceSettingsProvider::ApplyMetricsSetting(bool use_file,

<< "(use file : " << use_file << ")";

// TODO(pastarmovj): Remove this once we don't need to regenerate the

// consent file for the GUID anymore.

- ResolveMetricsReportingEnabled(new_value);

+ base::Callback<void(bool)> callback_fn;

Alexei Svitkine (slow) 2014/09/04 13:58:03 Nit: Just inline this into the call.

gayane -on leave until 09-2017 2014/09/04 18:35:46 Done.

+ InitiateMetricsReportingChange(callback_fn, new_value);

}

void DeviceSettingsProvider::ApplySideEffects(