Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Always pass all params to setMetricsReportingCheckboxState, minor changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.h
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.h b/chrome/browser/ui/webui/options/browser_options_handler.h
index 0c65c886ea4dd38974e0f89c2597059f3c4b72bf..66eb112d09ffa295d005597992dffe6453e1a3c9 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.h
+++ b/chrome/browser/ui/webui/options/browser_options_handler.h
@@ -327,6 +327,19 @@ class BrowserOptionsHandler
// Setup the UI for showing which settings are extension controlled.
void SetupExtensionControlledIndicators();
+ // Setup the value and the disabled property for metrics reporting for (except
+ // CrOS and Android).
+ void SetupMetricsReportingCheckbox();
+
+ // Called when the MetricsReportingEnabled checkbox values are changed.
+ // |args| will contain the checkbox checked state as a boolean.
+ void HandleMetricsReportingChange(const base::ListValue* args);
+
+ // Notifies the result of MetricsReportingEnabled change to Javascript layer.
+ void MetricsReportingChangeCallback(bool enabled);
+
+ // Calls a Javascript function to set the state of MetricsReporting checkbox.
+ void SetMetricsReportingCheckbox(bool checked, bool disabled);
Alexei Svitkine (slow) 2014/09/09 20:30:05 Add a blank line after this.
gayane -on leave until 09-2017 2014/09/10 16:58:27 Done.
#if defined(OS_CHROMEOS)
// Setup the accessibility features for ChromeOS.
void SetupAccessibilityFeatures();

Powered by Google App Engine
This is Rietveld 408576698