Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/ui/webui/options/browser_options_handler.h

Issue 506663003: Consolidates accessing and setting the UMA pref to be within metrics code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Always pass all params to setMetricsReportingCheckboxState, minor changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 320
321 // Setup the UI specific to managing supervised users. 321 // Setup the UI specific to managing supervised users.
322 void SetupManagingSupervisedUsers(); 322 void SetupManagingSupervisedUsers();
323 323
324 // Setup the UI for Easy Unlock. 324 // Setup the UI for Easy Unlock.
325 void SetupEasyUnlock(); 325 void SetupEasyUnlock();
326 326
327 // Setup the UI for showing which settings are extension controlled. 327 // Setup the UI for showing which settings are extension controlled.
328 void SetupExtensionControlledIndicators(); 328 void SetupExtensionControlledIndicators();
329 329
330 // Setup the value and the disabled property for metrics reporting for (except
331 // CrOS and Android).
332 void SetupMetricsReportingCheckbox();
333
334 // Called when the MetricsReportingEnabled checkbox values are changed.
335 // |args| will contain the checkbox checked state as a boolean.
336 void HandleMetricsReportingChange(const base::ListValue* args);
337
338 // Notifies the result of MetricsReportingEnabled change to Javascript layer.
339 void MetricsReportingChangeCallback(bool enabled);
340
341 // Calls a Javascript function to set the state of MetricsReporting checkbox.
342 void SetMetricsReportingCheckbox(bool checked, bool disabled);
Alexei Svitkine (slow) 2014/09/09 20:30:05 Add a blank line after this.
gayane -on leave until 09-2017 2014/09/10 16:58:27 Done.
330 #if defined(OS_CHROMEOS) 343 #if defined(OS_CHROMEOS)
331 // Setup the accessibility features for ChromeOS. 344 // Setup the accessibility features for ChromeOS.
332 void SetupAccessibilityFeatures(); 345 void SetupAccessibilityFeatures();
333 #endif 346 #endif
334 347
335 // Returns a newly created dictionary with a number of properties that 348 // Returns a newly created dictionary with a number of properties that
336 // correspond to the status of sync. 349 // correspond to the status of sync.
337 scoped_ptr<base::DictionaryValue> GetSyncStateDictionary(); 350 scoped_ptr<base::DictionaryValue> GetSyncStateDictionary();
338 351
339 scoped_refptr<ShellIntegration::DefaultBrowserWorker> default_browser_worker_; 352 scoped_refptr<ShellIntegration::DefaultBrowserWorker> default_browser_worker_;
(...skipping 22 matching lines...) Expand all
362 375
363 // Used to get WeakPtr to self for use on the UI thread. 376 // Used to get WeakPtr to self for use on the UI thread.
364 base::WeakPtrFactory<BrowserOptionsHandler> weak_ptr_factory_; 377 base::WeakPtrFactory<BrowserOptionsHandler> weak_ptr_factory_;
365 378
366 DISALLOW_COPY_AND_ASSIGN(BrowserOptionsHandler); 379 DISALLOW_COPY_AND_ASSIGN(BrowserOptionsHandler);
367 }; 380 };
368 381
369 } // namespace options 382 } // namespace options
370 383
371 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_ 384 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_BROWSER_OPTIONS_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698