net/test/spawned_test_server/spawner_communicator.cc - Issue 506523002: net : Declaring the weak_ptr_factory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/spawned_test_server/spawner_communicator.cc

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated the review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/test/spawned_test_server/spawner_communicator.cc

diff --git a/net/test/spawned_test_server/spawner_communicator.cc b/net/test/spawned_test_server/spawner_communicator.cc

index d7736b8d77bbad55e46c0513e058dbc6643172bb..9aadb87bb5f86dc7f45ffdda87ed37dad7ae9a66 100644

--- a/net/test/spawned_test_server/spawner_communicator.cc

+++ b/net/test/spawned_test_server/spawner_communicator.cc

@@ -103,8 +103,8 @@ SpawnerCommunicator::SpawnerCommunicator(uint16 port)

event_(false, false),

port_(port),

next_id_(0),

- weak_factory_(this),

- is_running_(false) {}

+ is_running_(false),

+ weak_factory_(this) {}

SpawnerCommunicator::~SpawnerCommunicator() {

DCHECK(!is_running_);

« net/http/http_cache_transaction.cc ('K') | « net/test/spawned_test_server/spawner_communicator.h ('k') | no next file » | no next file with comments »