Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: net/http/http_cache_transaction.cc

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated the review comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_transaction.h ('k') | net/http/http_proxy_client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index 286a526a3edb2fa39e7101e10429cf3c15b7920a..d0ee3dca4ba1d9b5ffbd56bd46d9ffd6c748651c 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -329,12 +329,13 @@ HttpCache::Transaction::Transaction(
read_offset_(0),
effective_load_flags_(0),
write_len_(0),
- weak_factory_(this),
- io_callback_(base::Bind(&Transaction::OnIOComplete,
- weak_factory_.GetWeakPtr())),
transaction_pattern_(PATTERN_UNDEFINED),
total_received_bytes_(0),
- websocket_handshake_stream_base_create_helper_(NULL) {
+ websocket_handshake_stream_base_create_helper_(NULL),
+ weak_factory_(this) {
+
Randy Smith (Not in Mondays) 2014/08/27 14:25:15 nit: I don't think there's any need for vertical w
+ io_callback_ = base::Bind(&Transaction::OnIOComplete,
+ weak_factory_.GetWeakPtr());
COMPILE_ASSERT(HttpCache::Transaction::kNumValidationHeaders ==
arraysize(kValidationHeaders),
Invalid_number_of_validation_headers);
Randy Smith (Not in Mondays) 2014/08/27 14:25:15 I have a slight preference for high level asserts
« no previous file with comments | « net/http/http_cache_transaction.h ('k') | net/http/http_proxy_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698