Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: net/http/http_proxy_client_socket_pool.h

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_proxy_client_socket_pool.h
diff --git a/net/http/http_proxy_client_socket_pool.h b/net/http/http_proxy_client_socket_pool.h
index a26c05f6603c9fbd1590eeac54682e8a830dbded..debe56837f25b4d4010e1f9e0515c39bf5ed40ac 100644
--- a/net/http/http_proxy_client_socket_pool.h
+++ b/net/http/http_proxy_client_socket_pool.h
@@ -152,14 +152,12 @@ class HttpProxyConnectJob : public ConnectJob {
// a standard net error code will be returned.
virtual int ConnectInternal() OVERRIDE;
- base::WeakPtrFactory<HttpProxyConnectJob> weak_ptr_factory_;
scoped_refptr<HttpProxySocketParams> params_;
TransportClientSocketPool* const transport_pool_;
SSLClientSocketPool* const ssl_pool_;
HostResolver* const resolver_;
State next_state_;
- CompletionCallback callback_;
scoped_ptr<ClientSocketHandle> transport_socket_handle_;
scoped_ptr<ProxyClientSocket> transport_socket_;
bool using_spdy_;
@@ -170,6 +168,9 @@ class HttpProxyConnectJob : public ConnectJob {
SpdyStreamRequest spdy_stream_request_;
+ base::WeakPtrFactory<HttpProxyConnectJob> weak_ptr_factory_;
+ CompletionCallback callback_;
+
DISALLOW_COPY_AND_ASSIGN(HttpProxyConnectJob);
};

Powered by Google App Engine
This is Rietveld 408576698