net : Declaring the weak_ptr_factory in proper order.

net/http/disk_cache_based_quic_server_info.h

Index: net/http/disk_cache_based_quic_server_info.h
diff --git a/net/http/disk_cache_based_quic_server_info.h b/net/http/disk_cache_based_quic_server_info.h
index 2a18ef5abc8df7375f95835959cf8cc5b3a93339..66052ad620ed251332a14f65b4bfde54b75643ef 100644
--- a/net/http/disk_cache_based_quic_server_info.h
+++ b/net/http/disk_cache_based_quic_server_info.h
@@ -84,9 +84,7 @@ class NET_EXPORT_PRIVATE DiskCacheBasedQuicServerInfo
   // DoSetDone is the terminal state of the write operation.
   int DoSetDone();
 
-  base::WeakPtrFactory<DiskCacheBasedQuicServerInfo> weak_factory_;
   CacheOperationDataShim* data_shim_;  // Owned by |io_callback_|.
-  CompletionCallback io_callback_;
   State state_;
   bool ready_;
   bool found_entry_;  // Controls the behavior of DoCreateOrOpen.
@@ -99,6 +97,9 @@ class NET_EXPORT_PRIVATE DiskCacheBasedQuicServerInfo
   scoped_refptr<IOBuffer> read_buffer_;
   scoped_refptr<IOBuffer> write_buffer_;
   std::string data_;
+
+  base::WeakPtrFactory<DiskCacheBasedQuicServerInfo> weak_factory_;
+  CompletionCallback io_callback_;

[Randy Smith (Not in Mondays), 2014/08/26 16:43:03]

I dislike making this exception to the general rule that the factory should be
the last thing.  Would it work to initialize the io_callback_ in the body of the
constructor, instead?  (Applies throughout review.)

[dmichael (off chromium), 2014/08/26 22:02:26]

+1, that's how I've been resolving these. Doing this may not be safe and the
clang plugin will eventually complain about it.

 };
 
 }  // namespace net