Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 506473003: pdf: Move the string/image resources for the pdf plugin. (Closed)

Created:
6 years, 3 months ago by sadrul
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, raymes, jam, blundell
CC:
chromium-reviews, darin-cc_chromium.org, jam, dcheng, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf-host-component
Project:
chromium
Visibility:
Public.

Description

pdf: Move the string/image resources for the pdf plugin. Move the resources for the pdf plugin out of //content into //components. Also, reuse the same code for getting the resource from PepperPDFHost and PPB_PDF_Impl. BUG=401242 R=blundell@chromium.org, jam@chromium.org, raymes@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8a0003bc269cfaabb44ce2db04046eb7a26bd78e

Patch Set 1 #

Total comments: 3

Patch Set 2 : tot-merge #

Patch Set 3 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -249 lines) Patch
M components/components_strings.grd View 1 chunk +1 line, -0 lines 0 comments Download
M components/pdf.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/pdf/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M components/pdf/renderer/DEPS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A components/pdf/renderer/pdf_resource_util.h View 1 chunk +24 lines, -0 lines 0 comments Download
A components/pdf/renderer/pdf_resource_util.cc View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.cc View 4 chunks +3 lines, -94 lines 0 comments Download
M components/pdf/renderer/ppb_pdf_impl.cc View 1 5 chunks +3 lines, -90 lines 0 comments Download
A components/pdf_strings.grdp View 1 chunk +17 lines, -0 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A + components/resources/default_100_percent/common/pdf/pan_icon.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftp.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftp_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftp_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftw.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftw_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_ftw_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_print.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_print_disabled.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_print_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_print_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_save.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_save_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_save_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin_end.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomout.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomout_hover.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_dropshadow.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_page_indicator_background.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_0.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_1.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_2.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_3.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_4.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_5.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_6.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_7.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_8.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_progress_background.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_0.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_1.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_2.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_3.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_4.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_5.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_6.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_7.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_8.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_9.png View Binary file 0 comments Download
A + components/resources/default_100_percent/common/pdf/pdf_thumbnail_num_background.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pan_icon.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftp.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftp_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftp_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftw.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftw_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_ftw_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_print.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_print_disabled.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_print_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_print_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_save.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_save_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_save_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin_end.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomout.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomout_hover.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_dropshadow.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_page_indicator_background.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_0.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_1.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_2.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_3.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_4.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_5.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_6.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_7.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_8.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_progress_background.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_0.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_1.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_2.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_3.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_4.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_5.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_6.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_7.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_8.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_9.png View Binary file 0 comments Download
A + components/resources/default_200_percent/common/pdf/pdf_thumbnail_num_background.png View Binary file 0 comments Download
A components/resources/pdf_scaled_resources.grdp View 1 chunk +51 lines, -0 lines 0 comments Download
M content/app/resources/content_resources.grd View 1 chunk +0 lines, -47 lines 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftp.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftp_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftp_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftw.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftw_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_ftw_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_print.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_print_disabled.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_print_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_print_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_save.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_save_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_save_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin_end.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomout.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomout_hover.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_dropshadow.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_page_indicator_background.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_0.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_1.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_2.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_3.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_4.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_5.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_6.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_7.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_8.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_progress_background.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_0.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_1.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_2.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_3.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_4.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_5.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_6.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_7.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_8.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_9.png View Binary file 0 comments Download
D content/app/resources/default_100_percent/pdf_thumbnail_num_background.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftp.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftp_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftp_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftw.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftw_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_ftw_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_print.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_print_disabled.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_print_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_print_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_save.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_save_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_save_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin_end.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomout.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomout_hover.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_dropshadow.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_page_indicator_background.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_0.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_1.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_2.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_3.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_4.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_5.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_6.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_7.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_8.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_progress_background.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_0.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_1.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_2.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_3.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_4.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_5.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_6.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_7.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_8.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_9.png View Binary file 0 comments Download
D content/app/resources/default_200_percent/pdf_thumbnail_num_background.png View Binary file 0 comments Download
M content/app/strings/content_strings.grd View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sadrul
sadrul@chromium.org changed reviewers: + jam@chromium.org, raymes@chromium.org, thestig@chromium.org
6 years, 3 months ago (2014-08-26 21:48:35 UTC) #1
sadrul
This goes on top of https://codereview.chromium.org/505243003/ and https://codereview.chromium.org/477263003/
6 years, 3 months ago (2014-08-26 21:48:35 UTC) #2
Lei Zhang
This generally looks good. https://codereview.chromium.org/506473003/diff/1/components/pdf/renderer/pdf_resource_util.cc File components/pdf/renderer/pdf_resource_util.cc (right): https://codereview.chromium.org/506473003/diff/1/components/pdf/renderer/pdf_resource_util.cc#newcode20 components/pdf/renderer/pdf_resource_util.cc:20: static const ResourceImageInfo kResourceImageMap[] = ...
6 years, 3 months ago (2014-08-26 22:05:53 UTC) #3
raymes
lgtm https://codereview.chromium.org/506473003/diff/1/components/pdf/renderer/pdf_resource_util.cc File components/pdf/renderer/pdf_resource_util.cc (right): https://codereview.chromium.org/506473003/diff/1/components/pdf/renderer/pdf_resource_util.cc#newcode110 components/pdf/renderer/pdf_resource_util.cc:110: return base::UTF16ToUTF8(l10n_util::GetStringUTF16(resource_id)); What happens in the case where ...
6 years, 3 months ago (2014-08-27 03:15:42 UTC) #4
jam
rubberstamp lgtm
6 years, 3 months ago (2014-08-27 03:35:04 UTC) #5
sadrul
sadrul@chromium.org changed reviewers: + blundell@chromium.org
6 years, 3 months ago (2014-08-28 19:51:43 UTC) #6
sadrul
blundell@chromium.org for changes in the grdp/grd files, and component/resources/ owners.
6 years, 3 months ago (2014-08-28 19:51:43 UTC) #7
blundell
LGTM I'm going to send you an email with the steps you need to take ...
6 years, 3 months ago (2014-09-01 11:37:32 UTC) #8
sadrul
Committed patchset #3 (id:40001) manually as 8a0003b (presubmit successful).
6 years, 3 months ago (2014-09-02 04:18:21 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:40 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a0003bc269cfaabb44ce2db04046eb7a26bd78e
Cr-Commit-Position: refs/heads/master@{#292897}

Powered by Google App Engine
This is Rietveld 408576698