Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 506413004: Simplify SkGpuDevice construction (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cons
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also remove init from header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -44 lines) Patch
M include/gpu/SkGpuDevice.h View 1 2 chunks +1 line, -12 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +8 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
bsalomon@google.com changed reviewers: + robertphillips@google.com
6 years, 3 months ago (2014-08-28 21:25:11 UTC) #1
bsalomon
Combines the two cons and the init function into one cons. Not strictly related, but ...
6 years, 3 months ago (2014-08-28 21:25:11 UTC) #2
reed1
reed@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-28 21:30:53 UTC) #3
reed1
When can we make SkGpuDevice.h private?
6 years, 3 months ago (2014-08-28 21:30:54 UTC) #4
robertphillips
lgtm + a naming suggestion https://codereview.chromium.org/506413004/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/506413004/diff/1/src/gpu/SkGpuDevice.cpp#newcode156 src/gpu/SkGpuDevice.cpp:156: // busting chrome (for ...
6 years, 3 months ago (2014-08-28 21:37:35 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-29 14:03:40 UTC) #6
bsalomon
https://codereview.chromium.org/506413004/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/506413004/diff/1/src/gpu/SkGpuDevice.cpp#newcode156 src/gpu/SkGpuDevice.cpp:156: // busting chrome (for a currently unknown reason). On ...
6 years, 3 months ago (2014-08-29 14:03:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/506413004/20001
6 years, 3 months ago (2014-08-29 14:04:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 32d0b3b5463c11032f12d03d993f11ea0af05959
6 years, 3 months ago (2014-08-29 14:50:27 UTC) #9
bsalomon
6 years, 3 months ago (2014-08-29 14:53:24 UTC) #10
Message was sent while issue was closed. 
On 2014/08/28 21:30:54, reed1 wrote:
> When can we make SkGpuDevice.h private?

After the raster clip is removed :)

https://code.google.com/p/chromium/codesearch#search/&q=SkGpuDevice&sq=packag...

src/cc/output/gl_renderer.cc looks like the only real user. ApplyImageFilter and
ApplyBlendModeWithBackdrop.

src/cc/resources/resource_provider.cc #includes it but doesn't seem to use it.

Powered by Google App Engine
This is Rietveld 408576698